Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsPDF to 2.5 #3909

Closed
7 tasks done
owlbrudder opened this issue Dec 23, 2023 · 5 comments
Closed
7 tasks done

Upgrade jsPDF to 2.5 #3909

owlbrudder opened this issue Dec 23, 2023 · 5 comments
Assignees
Labels

Comments

@owlbrudder
Copy link
Collaborator

Background information

IMPORTANT: If you choose to ignore this issue report template, your issue will be closed as we cannot help without the requested information.

Please make sure you tick (add an x between the square brackets with no spaces) the following check boxes:

  • Reporting an issue of an unmodified OSPOS installation
  • Checked open and closed issues and no similar issue was already reported (please make sure you searched!)
  • Read README, WHATS_NEW, INSTALL.md and UPGRADE
  • Read the FAQ for any known install and/or upgrade gotchas (in specific PHP extensions installed)
  • Read the wiki
  • Executed any database upgrade scripts if an upgrade pre 3.0.0 (e.g. database/2.4_to_3.0.sql)
  • Aware the installation code that GitHub master is for developers only and therefore not complete nor stable.

Installation information

  • OSPOS version is: 3.4.0-dev
  • OSPOS git commit hash is: ceea0fe
  • PHP version is: 8.2.14
  • MySQL or MariaDB version is: 10.5.23-MariaDB
  • OS and version is: Linux 6.6.7-100.fc38.x86_64
  • WebServer is: Apache/2.4.58 (Fedora Linux) mod_wsgi/4.9.4 Python/3.11 mod_perl/2.0.12 Perl/v5.36.3
  • Selected language is: en-US
  • (If applicable) Docker installation:
  • (If applicable) Installation package for the LAMP/LEMP stack is:

Issue / Bug / Question / New Feature

I have just moved from PHP 7.4.x to PHP 8.2.x and this required new copies of composer and npm. When I ran npm install, it complained about an old version of uuid. To correct this, I ran npm install uuid@latest. As this it finished, the automatic audit reported 2 critical vulnerabilities (20 vulnerabilities in total). I mentioned this on the devroom thread and jekkos asked me to raise an issue which he would look at sometime.

@jekkos jekkos self-assigned this Dec 23, 2023
@jekkos jekkos added the bug label Dec 23, 2023
@jekkos
Copy link
Member

jekkos commented Dec 24, 2023

We do have a couple of dependabot alerts open
https://github.com/opensourcepos/opensourcepos/security/dependabot

@jekkos
Copy link
Member

jekkos commented Dec 24, 2023

Tried to run npm audit fix --force and strangely enough it suggested to downgrade gulp and pdf export library. Also one of the alerts is about a library we use and a potential XSS vulnerability it has. I don't think we are affected by that.

jekkos added a commit that referenced this issue Dec 29, 2023
@jekkos
Copy link
Member

jekkos commented Dec 29, 2023

Reduced the critiical warnings by one. Fixing the other issue would require a jspdt upgrade to 2.5.x .Currently bootstrap table depends on 1.x so that will be a breaking change. Will need to investigate further if this is really the only way and if that upgrade would potentially break something in our functionality.

@jekkos
Copy link
Member

jekkos commented Jan 3, 2024

jspdf might need an upgrade if I understand #3894 correctly

@objecttothis
Copy link
Member

jspdf might need an upgrade if I understand #3894 correctly

Yes, the current version of jspdf does not work properly.

@jekkos jekkos changed the title npm audit reporting two critical errors Upgrade jsPDF to 2.5 Apr 29, 2024
jekkos added a commit that referenced this issue Apr 29, 2024
jekkos added a commit that referenced this issue Apr 29, 2024
jekkos added a commit that referenced this issue Apr 30, 2024
jekkos added a commit that referenced this issue Apr 30, 2024
@jekkos jekkos closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants