Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify oso ci-default workflow for external PRs #1378

Open
ryscheng opened this issue May 7, 2024 · 0 comments
Open

Simplify oso ci-default workflow for external PRs #1378

ryscheng opened this issue May 7, 2024 · 0 comments

Comments

@ryscheng
Copy link
Member

ryscheng commented May 7, 2024

What is it?

Currently we do this thing where we build docker containers that embed our secrets so that we can approve and trigger external PRs that use our secrets.

There's a simpler approach here:
https://dvc.ai/blog/testing-external-contributions-using-github-actions-secrets

FWIW, we will want to continue use the GitHub app for these purposes:

  • test-deploy in OSO because it runs up our GCP bill to do the dbt run. We want to trigger each run against a git commit SHA
  • oss-directory validation checks, which will check for different validation criteria and have a nice way to report errors to the user's PR
@ryscheng ryscheng added this to the (c) Data warehouse milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant