Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pray for poetry workspaces #1377

Open
3 tasks
ryscheng opened this issue May 7, 2024 · 1 comment
Open
3 tasks

Pray for poetry workspaces #1377

ryscheng opened this issue May 7, 2024 · 1 comment

Comments

@ryscheng
Copy link
Member

ryscheng commented May 7, 2024

What is it?

Currently the python packages in our repo basically operate in the context of a giant pyproject. This is because we want to have common libraries that reference each other, like you would in a typical monorepo.
Poetry doesn't seem to have the concept of workspaces like yarn or pnpm does, so it doesn't handle this kind of cross-linking gracefully.

This is the main thing that prevents us from having pyproject.toml files in every separate package with its own scripts and dependencies like you would expect in a purely Node.js monorepo

Once poetry workspaces exists, we can

  • Create a pyproject.toml for each python package
  • Create a package.json for each python package that wraps poetry run commands that can be handled by Turbo monorepo
  • Actually use Turbo in the way we expect for all Python packages
@ryscheng ryscheng added this to the (c) Data warehouse milestone May 7, 2024
@ravenac95
Copy link
Member

🙏 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants