Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate contract artifacts from a factory address #1374

Closed
ryscheng opened this issue May 7, 2024 · 3 comments · Fixed by #1493
Closed

Enumerate contract artifacts from a factory address #1374

ryscheng opened this issue May 7, 2024 · 3 comments · Fixed by #1493
Assignees
Labels
c:data Gathering data (e.g. indexing) P0 Highest priority issue
Milestone

Comments

@ryscheng
Copy link
Member

ryscheng commented May 7, 2024

What is it?

Currently we only enumerate contracts that are created by deployer address.
We do not detect whether they're a factory and whether that factory in turn creates new contracts.

These should all be artifacts in our data model

@ryscheng ryscheng added this to the (c) Op RF4 milestone May 7, 2024
@ccerv1 ccerv1 added the c:data Gathering data (e.g. indexing) label May 9, 2024
@ccerv1

This comment was marked as outdated.

@ccerv1

This comment was marked as outdated.

@ccerv1
Copy link
Member

ccerv1 commented May 20, 2024

@ravenac95 I have moved our discussion about the contract verification that we were having with Jonas and Agora into its own issue now. Please add any comments or additional context that may be relevant to that issue.

Separately, my understanding is that this feature should be working now. We just want to test it, eg, by adding a deployer on Base that deployed a factory. If so, we can close this out once we get #1203 to work.

@ccerv1 ccerv1 added the P0 Highest priority issue label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:data Gathering data (e.g. indexing) P0 Highest priority issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants