Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hasura deploy in GitHub actions is broken #1342

Closed
ryscheng opened this issue May 1, 2024 · 1 comment
Closed

Hasura deploy in GitHub actions is broken #1342

ryscheng opened this issue May 1, 2024 · 1 comment
Assignees
@ryscheng
Milestone
(c) Data warehouse

Comments

@ryscheng
Copy link
Member

ryscheng commented May 1, 2024

What is it?

genTables fails silently, so that the CI shows green check marks

We should

  • Update genTables to fail loudly if we don't get a DBT_TARGET
  • Then update the job to actually specify the production target
@ryscheng ryscheng self-assigned this May 1, 2024
@ryscheng ryscheng added this to the (c) Data warehouse milestone May 5, 2024
@ryscheng
Copy link
Member Author

Fix here
#1464

@ryscheng ryscheng mentioned this issue May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryscheng ryscheng

Labels
None yet
Projects
OSO
Status: Done
Milestone
(c) Data warehouse
Development

No branches or pull requests
1 participant
@ryscheng