Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test: Expand test coverage for HyperShift supported features #2455

Open
hasueki opened this issue Apr 20, 2023 · 8 comments
Open

E2E Test: Expand test coverage for HyperShift supported features #2455

hasueki opened this issue Apr 20, 2023 · 8 comments

Comments

@hasueki
Copy link
Contributor

hasueki commented Apr 20, 2023

Requesting Red Hat e2e testing to cover wider sets of common features that HyperShift supports to ensure stability in the subsequent releases. Some of these features may include, but not limited to:

  • Bring your own PKI:
    DisablePKIReconciliationAnnotation = "hypershift.openshift.io/disable-pki-reconciliation"
  • Disabling control plane profiling:
    // DisableProfilingAnnotation is the annotation that allows disabling profiling for control plane components.
    // Any components specified in this list will have profiling disabled. Profiling is disabled by default for etcd and konnectivity.
    // Components this annotation can apply to: kube-scheduler, kube-controller-manager, kube-apiserver.
    DisableProfilingAnnotation = "hypershift.openshift.io/disable-profiling"
  • OLM catalogs in guest cluster:
    // OLMCatalogPlacement specifies the placement of OLM catalog components. By default,
    // this is set to management and OLM catalog components are deployed onto the management
    // cluster. If set to guest, the OLM catalog components will be deployed onto the guest
    // cluster.
    //
    // +kubebuilder:default=management
    // +optional
    // +immutable
    OLMCatalogPlacement OLMCatalogPlacement `json:"olmCatalogPlacement,omitempty"`
  • Priority class overrides:
    ControlPlanePriorityClass = "hypershift.openshift.io/control-plane-priority-class"
    // APICriticalPriorityClass is for pods that are required for API calls and resource admission to succeed. This includes pods like kube-apiserver, aggregated API servers, and webhooks.
    APICriticalPriorityClass = "hypershift.openshift.io/api-critical-priority-class"
    // EtcdPriorityClass is for etcd pods.
    EtcdPriorityClass = "hypershift.openshift.io/etcd-priority-class"
  • ...
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 19, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki
Copy link
Contributor Author

hasueki commented Nov 17, 2023

/remove-lifecycle rotten

@hasueki
Copy link
Contributor Author

hasueki commented Nov 17, 2023

/reopen

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 17, 2023
@openshift-ci openshift-ci bot reopened this Nov 17, 2023
Copy link
Contributor

openshift-ci bot commented Nov 17, 2023

@hasueki: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brucejcong
Copy link
Contributor

brucejcong commented Feb 13, 2024

PRs:
#2989
openshift/release#43084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants