Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow operators to run with reduced list of platform CRDs #1878

Open
isco-rodriguez opened this issue Nov 18, 2022 · 8 comments
Open

Allow operators to run with reduced list of platform CRDs #1878

isco-rodriguez opened this issue Nov 18, 2022 · 8 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@isco-rodriguez
Copy link
Contributor

isco-rodriguez commented Nov 18, 2022

At the moment, the hypershift operator and the control plane operator have issues when reducing the list of platform CRDs due to corresponding watches

e.g.

hypershift operator logs
{"level":"error","ts":"2022-10-26T14:57:51Z","logger":"controller-runtime.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":"AzureMachineTemplate.infrastructure.cluster.x-k8s.io","error":"no matches for kind \"AzureMachineTemplate\" in version \"infrastructure.cluster.x-k8s.io/v1beta1\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start.func1.1\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/source/source.go:139\nk8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtectionWithContext\n\t/hypershift/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:233\nk8s.io/apimachinery/pkg/util/wait.poll\n\t/hypershift/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:580\nk8s.io/apimachinery/pkg/util/wait.PollImmediateUntilWithContext\n\t/hypershift/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:545\nsigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start.func1\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/source/source.go:132"}

control plane operator logs
{"level":"error","ts":"2022-10-26T17:27:53Z","logger":"setup","msg":"problem running manager","error":"failed to wait for awsendpointservice caches to sync: timed out waiting for cache to be synced","stacktrace":"main.NewStartCommand.func1\n\t/hypershift/control-plane-operator/main.go:415\ngithub.com/spf13/cobra.(*Command).execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:860\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:974\ngithub.com/spf13/cobra.(*Command).Execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:902\nmain.main\n\t/hypershift/control-plane-operator/main.go:65\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:250"}

we can add a way to specify at the operator level whether you support a particular platform, so we can omit the corresponding watches

@isco-rodriguez isco-rodriguez changed the title Allow operators to run with with reduced list of platform CRDs Allow operators to run with reduced list of platform CRDs Nov 18, 2022
@isco-rodriguez
Copy link
Contributor Author

/assign @isco-rodriguez

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 19, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Apr 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hasueki
Copy link
Contributor

hasueki commented Jan 19, 2024

/reopen

@openshift-ci openshift-ci bot reopened this Jan 19, 2024
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@hasueki: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng
Copy link
Contributor

csrwng commented Feb 13, 2024

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants