Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][opensearch] readinessProbe uses tcp socket instead of health api endpoint & no livenessProbe #307

Closed
kamil-stc opened this issue Aug 10, 2022 · 3 comments
Labels
question Further information is requested

Comments

@kamil-stc
Copy link

kamil-stc commented Aug 10, 2022

Is your feature request related to a problem? Please describe.
Recently we had an issue when running opensearch 2.1 in k8s cluster (1.22.9). When one of the coordinating nodes is being evicted filebeat's start having connection issues. We are currently testing it with changed readinessProbe to http. Due to helm/helm#5184 it is not possible to overwrite values shipped with embedded helm chart.

Testing if port 9200 is open might be not enough to check if the pod is healthy. Also lack of livenessProbe might lead to directing traffic to pods that are not running.

Describe the solution you'd like
Change readinessProbe to checking health check endpoint over http (https://opensearch.org/docs/1.2/security-plugin/access-control/api/#health-check). It might also be useful to have livenessProbe defined with the same endpoint.

Describe alternatives you've considered
None

Additional context
Add any other context or screenshots about the feature request here.

@kamil-stc kamil-stc added enhancement New feature or request untriaged Issues that have not yet been triaged labels Aug 10, 2022
@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Aug 30, 2022
@prudhvigodithi
Copy link
Collaborator

Hey @kamil-stc the link you provided is specific to the security plugin, the health check endpoint should be for the cluster alone.
@TheAlgo can you add your thoughts from this PR #172

@TheAlgo
Copy link
Member

TheAlgo commented Aug 31, 2022

@kamil-stc There were various cases because of which it was decided to not use an authenticated probe. It will be great if you can read through the conversations in the PR to understand why this decision was taken

#172 (comment)

@TheAlgo TheAlgo added question Further information is requested and removed enhancement New feature or request labels Nov 3, 2022
@TheAlgo
Copy link
Member

TheAlgo commented Nov 3, 2022

Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants