Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Move Manufacturer class out from under motor #2482

Open
JoePfeiffer opened this issue May 9, 2024 · 0 comments
Open

[Feature Request] Move Manufacturer class out from under motor #2482

JoePfeiffer opened this issue May 9, 2024 · 0 comments

Comments

@JoePfeiffer
Copy link
Contributor

The Manufacturer class was originally created to be specific to motor manufacturers, so it is in the motor package. At some point it also started being used for manufacturers of other components, and at this point has at least two manufacturers that don't even manufacture motors. The motor type member should be removed (I'm not sure why that was relevant even when it was only motor manufacturers), and the class moved somewhere else (not quite sure where).

This is not urgent as the change would be completely transparent to users, but would be a little bit of code cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant