Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Parts of components database are in two different places in the source tree, and only one is ending up being loaded at run time #2479

Closed
JoePfeiffer opened this issue Apr 24, 2024 · 1 comment · Fixed by #2481
Assignees
Labels
beta blocker Beta Release Blocker bug

Comments

@JoePfeiffer
Copy link
Contributor

Describe the bug

The openrocket-database is now in the source tree at .../core/resources-src/datafiles/openrocket-database/orc/
while the legacy database (including components that don't appear in openrocket-database) is at .../core/src/main/resources/datafiles/presets/

When OR is built, it ends up with several subdirectories under .../core/build/resources/main/datafiles/ containing parts of the database. I think without checking carefully that .../components/ is openrocket-database, .../components-openrocket is the legacy database, and .../presets combines them. At runtime, only .../components/ is loaded.

To Reproduce

Open the attached .ork file under current unstable

Screenshots / .ork file

The attached .ork file loads under 23.09, but gets many "No matching component preset" errors under current unstable
double-the-fun.zip

OpenRocket version

unstable (regression from 23.09)

What platform are you running on?

Linux

Additional context

No response

@JoePfeiffer
Copy link
Contributor Author

All the comments in .../ComponentPresetDatabaseLoader.java indicate that components will be loaded from .../datafiles/presets/ but they're actually loaded from .../datafiles/components/. Changing the code to match the comments ought to bring in everything, but with that change I'm still not finding the LOC/Precision parts used in that .ork file...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta blocker Beta Release Blocker bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants