Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Simulation with warning loaded from file does not match user unit #2475

Open
SiboVG opened this issue Apr 9, 2024 · 0 comments
Open
Labels
bug good first issue Good issue for first time contributors release blocker Release blocking bug

Comments

@SiboVG
Copy link
Member

SiboVG commented Apr 9, 2024

Describe the bug

When saving simulation data to a .ork file, the simulation warnings are also stored. However, any numerical values stored in the warning are stored using the units of the person who saved the sim. If person that saved the sim uses imperial units and I have metric units, then when I open the file, the warning message will have values in imperial units.

The warning message should always adapt to use the user's units.

To Reproduce

  1. Set your unit preferences to metrics
  2. Open 'A simple model rocket'
  3. Open the warnings tab of Simulation 3
  4. The deployment speed unit is in mph instead of m/s
  5. Rerun Simulation 3, open the sim warning dialog again
  6. Unit is now m/s

Screenshots / .ork file

Screenshot(s):

image

OpenRocket version

unstable

What platform are you running on?

macOS

Additional context

No response

@SiboVG SiboVG added bug good first issue Good issue for first time contributors release blocker Release blocking bug labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good issue for first time contributors release blocker Release blocking bug
Projects
None yet
Development

No branches or pull requests

1 participant