Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motor selection: Quest vs. AeroTech motors #2469

Open
neilweinstock opened this issue Mar 15, 2024 · 2 comments
Open

Motor selection: Quest vs. AeroTech motors #2469

neilweinstock opened this issue Mar 15, 2024 · 2 comments

Comments

@neilweinstock
Copy link
Contributor

18mm Q-jets are listed under manufacturer "Quest".

24mm Q-jets are listed under manufacturer "AeroTech".

All these motors are of course manufactured by AeroTech, but they are sold as part of the Quest product line. It is annoying that they are not all grouped together accordingly in the motor selection table. I went looking for the 24mm Q-jets and was baffled why they were not listed under Quest, until it eventually occurred to me to look under AeroTech.

I realize all this comes from thrustcurve.org but wonder if there's a way we can clean it up on our end to make it more straightforward for the user.

@JoePfeiffer
Copy link
Contributor

The Manufacturer.java file seems to be loaded with heuristics for trying to figure out what different manufacturer names are really the same manufacturer. I took a look once, and decided I had better rabbit holes to explore...

@neilweinstock
Copy link
Contributor Author

For this issue the responsibility probably lies with thrustcurve.org, but if John can't fix it on his end then we should think about doing it on our end... even if we have to have an enumerated list of motors that get the manufacturer field change. Let's wait and see how that plays out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants