From 98efffd877dabb522705d00b050dc2551912488f Mon Sep 17 00:00:00 2001 From: Sam Snyder Date: Fri, 15 Mar 2024 18:58:24 -0700 Subject: [PATCH] Polish --- .../java/org/openrewrite/maven/AddManagedDependency.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/rewrite-maven/src/main/java/org/openrewrite/maven/AddManagedDependency.java b/rewrite-maven/src/main/java/org/openrewrite/maven/AddManagedDependency.java index 5d5e365d694..9431d45774a 100644 --- a/rewrite-maven/src/main/java/org/openrewrite/maven/AddManagedDependency.java +++ b/rewrite-maven/src/main/java/org/openrewrite/maven/AddManagedDependency.java @@ -142,7 +142,7 @@ public String getDescription() { return "Add a managed Maven dependency to a `pom.xml` file."; } - static class Scanned { + public static class Scanned { boolean usingType; List rootPoms = new ArrayList<>(); } @@ -164,7 +164,7 @@ public Xml.Document visitDocument(Xml.Document document, ExecutionContext ctx) { acc.rootPoms.add(document); } }); - if(acc.usingType) { + if (acc.usingType) { return SearchResult.found(document); } @@ -201,6 +201,9 @@ public Xml visitDocument(Xml.Document document, ExecutionContext ctx) { if (!Boolean.TRUE.equals(addToRootPom) || acc.rootPoms.contains(document)) { ResolvedPom pom = getResolutionResult().getPom(); String convertedVersion = pom.getValue(version); + if (convertedVersion == null) { + return maven; + } Validated versionValidation = Semver.validate(convertedVersion, versionPattern); if (versionValidation.isValid()) { VersionComparator versionComparator = requireNonNull(versionValidation.getValue());