Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] JobSidecarTerminator support exec sidecar preStop bash #1486

Closed
zmberg opened this issue Jan 11, 2024 · 1 comment · May be fixed by #1506
Closed

[feature request] JobSidecarTerminator support exec sidecar preStop bash #1486

zmberg opened this issue Jan 11, 2024 · 1 comment · May be fixed by #1506
Assignees
@huangchenzhao
Labels
kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea

Comments

@zmberg
Copy link
Member

zmberg commented Jan 11, 2024

What would you like to be added:
job sidecar terminator can watch and terminate sidecar containers for such job-type Pods when its main containers completed.

But, currently jobsidecarterminator does not execute the sidecar preStop bash.

Expectly, jobsidecarterminator also can execute sidecar container preStop bash. The relevant code https://github.com/openkruise/kruise/blob/master/pkg/controller/sidecarterminator/kill_container_action.go#L52
@xiangpingjiang xiangpingjiang removed their assignment Jan 15, 2024
@huangchenzhao
Copy link

hello, I am new to kruise, and I want to try this issue :)

@hantmac hantmac mentioned this issue Feb 19, 2024
Open
@zmberg zmberg closed this as completed Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huangchenzhao huangchenzhao

Labels
kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: JobSidecarTerminator support exec sidecar preStop hantmac/kruise
3 participants
@zmberg @xiangpingjiang @huangchenzhao