Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] SidecarSet add upgrade state in pod annotation #1312

Open
zmberg opened this issue Jun 13, 2023 · 4 comments · May be fixed by #1349
Open

[feature request] SidecarSet add upgrade state in pod annotation #1312

zmberg opened this issue Jun 13, 2023 · 4 comments · May be fixed by #1349
Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers
Projects
Roadmap
Milestone
1.7

Comments

@zmberg
Copy link
Member

zmberg commented Jun 13, 2023 •
edited

What would you like to be added:
SidecarSet can publish Sidecar containers in batches, and currently needs to add a representation to make it easier for upper-level paas to support more clearly which Pods are in the process of being published and which are finished.

Currently Pod have sidecarset annotations[kruise.io/sidecarset-hash] and value is struct:

type SidecarSetUpgradeSpec struct {
	UpdateTimestamp              metav1.Time `json:"updateTimestamp"`
	SidecarSetHash               string      `json:"hash"`
	SidecarSetName               string      `json:"sidecarSetName"`
	SidecarList                  []string    `json:"sidecarList"`                  // sidecarSet container list
	SidecarSetControllerRevision string      `json:"controllerRevision,omitempty"` // sidecarSet controllerRevision name
}

So we can add field in the above struct:

type SidecarSetUpgradeSpec struct {
	...
         // enum: Normal, Updating
        State string `json:"state"`
}

Related Code: https://github.com/openkruise/kruise/blob/master/pkg/control/sidecarcontrol/util.go#L63
@zmberg zmberg added help wanted Extra attention is needed kind/good-first-issue Good for newcomers kind/feature-request labels Jun 13, 2023
@zmberg zmberg added this to the v1.5 milestone Jun 13, 2023
@zmberg zmberg added this to Proposal in Roadmap via automation Jun 13, 2023
@xiangpingjiang
Copy link
Contributor

/assign

@xiangpingjiang
Copy link
Contributor

The value of sidecarset annotations[kruise.io/sidecarset-inplace-update-state] is here.

The value of sidecarset annotations[kruise.io/sidecarset-hash] is here.

Maybe you have confused these two annotations @zmberg

@zmberg
Copy link
Member Author

zmberg commented Jul 11, 2023

Yes, you are right. You can update the sidecarset annotations[kruise.io/sidecarset-hash]

@xiangpingjiang
Copy link
Contributor

Yes, you are right. You can update the sidecarset annotations[kruise.io/sidecarset-hash]

Ok, I will do that recentlly

@xiangpingjiang xiangpingjiang linked a pull request Jul 28, 2023 that will close this issue
Open
@xiangpingjiang xiangpingjiang removed their assignment Feb 21, 2024
@zmberg zmberg modified the milestones: v1.5, 1.6, 1.7 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers
Projects
Roadmap
  
Proposal
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

SidecarSet add upgrade state in pod annotation xiangpingjiang/kruise
2 participants
@zmberg @xiangpingjiang