Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Scientific programming in Julia - An introductory course #242

Open
editorialbot opened this issue Apr 4, 2024 · 9 comments
Open

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @AndreasKuhn-ak (Andreas Kuhn)
Repository: https://github.com/AndreasKuhn-ak/WS2022_Julia
Branch with paper.md (empty if default branch):
Version: V1.0.0
Editor: @arm61
Reviewers: @jarvist, @gcdeshpande
Archive: Pending
Paper kind: learning module

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/f53501246f3b960a2a7bab3797a85546"><img src="https://jose.theoj.org/papers/f53501246f3b960a2a7bab3797a85546/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/f53501246f3b960a2a7bab3797a85546/status.svg)](https://jose.theoj.org/papers/f53501246f3b960a2a7bab3797a85546)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jarvist & @gcdeshpande, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html. Any questions/concerns please let @arm61 know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@jarvist, please create your checklist typing: @editorialbot generate my checklist

@gcdeshpande, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (424.4 files/s, 602629.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                              5              1              0          37679
Jupyter Notebook                18              0          10687           1974
TOML                             2            254              1           1156
TeX                              1             18              0            261
Julia                            2             43             20            201
Markdown                         2             91              0            121
YAML                             1              1              4             18
JSON                             6              0              0              6
-------------------------------------------------------------------------------
SUM:                            37            408          10712          41416
-------------------------------------------------------------------------------

Commit count by author:

    98	AndreasKuhn-ak
    15	Sabine Fischer
     6	Kilian Volmer
     2	HackMD

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/d41586-019-02310-3 is OK
- 10.1137/141000671 is OK
- 10.48550/arXiv.1209.5145 is OK
- 10.1016/j.cosrev.2020.100254 is OK
- 10.48550/arXiv.2109.09973 is OK
- 10.1016/j.cpc.2018.02.004 is OK
- 10.21105/joss.03349 is OK
- 10.1002/mrm.28792 is OK
- 10.1007/s10614-020-09983-3 is OK
- 10.1371/journal.pone.0209358 is OK
- 10.48550/arXiv.2211.02740 is OK
- 10.48550/arXiv.2212.07293 is OK
- 10.21105/joss.03349 is OK

MISSING DOIs

- No DOI given, and none found for title: How to solve the same numerical Problem in 7 diffe...
- No DOI given, and none found for title: Julia Language Delivers Petascale HPC Performance
- No DOI given, and none found for title: Julia Micro-Benchmarks

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1166

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arm61
Copy link

arm61 commented Apr 4, 2024

It looks to me that the license for the code is MIT and the license for the material is CC-SA-4.0. Can you confirm this @AndreasKuhn-ak?

@arm61
Copy link

arm61 commented Apr 4, 2024

Okay, we are ready to roll!

@jarvist and @gcdeshpande, thanks for agreeing to review this exciting work! If you work through the checklist and there are any problems/comments about the material, I recommend opening an issue on the material repository, and the authors can sort them out. More information about the review guidelines can be found on the Open Journals documentation pages: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html

If anyone has any questions, ping me on here!

@AndreasKuhn-ak
Copy link

It looks to me that the license for the code is MIT and the license for the material is CC-SA-4.0. Can you confirm this @AndreasKuhn-ak?

Yes, that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants