Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path exceptions are excluded from generated classpath despite includePathExceptionsInClasspath is set #162

Open
martinleim opened this issue Dec 30, 2022 · 1 comment

Comments

@martinleim
Copy link

martinleim commented Dec 30, 2022

I have been building an application which has JAR dependencies that do not declare a module descriptor. The application itself is non-modular as well (this is important, see below). When running my application with javafx:run, the plugin tries to determine automatic module names for all the dependencies, but it fails at some of them. As a result, these dependencies are missing in the classpath.

I understand that's why the configuration switch includePathExceptionsInClasspath has been introduced (see #18). Unfortunately, after activating this switch, the dependencies were still missing from classpath.

I found out that the code that adds the path exceptions is only executed if the JavaFX app itself is modular. Is this intentional or has there been an oversight?

Since making my app modular is not an option for me (it would be possible, but would involve rebundling external JARs, which I want to avoid), I have created a fork where I always add the path exceptions to classpath, no matter if the app is modular or not. Is there an interest in integrating this change? If yes, then you can merge this PR: #163

@amischler
Copy link

Same issue here. It could be great to see that PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants