Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this lib for oAuth flow #1039

Open
xuanpan opened this issue Jan 26, 2024 · 2 comments
Open

Using this lib for oAuth flow #1039

xuanpan opened this issue Jan 26, 2024 · 2 comments
Labels

Comments

@xuanpan
Copy link

xuanpan commented Jan 26, 2024

Description

Dear community. We are considering using this lib in our apps for oAuth flow but could not stop wondering why the last release was done almost two years ago?

Do you have planned upcoming releases? If so, how soon otherwise, Do you recommend us to use this library?

@xuanpan
Copy link
Author

xuanpan commented Jan 26, 2024

More specifically, we would like to use this library for implementing the PKCE flow

@agologan
Copy link
Collaborator

Despite the version, the library it has been good enough for most uses for a very long time. (at least 2018)

Historically, the login flow was broken several times due to OS level changes in Android pre-release versions only to get fixed by the Google team before the final release.
Android Custom Tabs work best in Chrome (to be expected). This has caused issues in the past when users set their default browser to another with improper implementation. This is neither our fault or the library integrators'. The lib integrator can deny a browser temporarily if they know a significant part of their userbase uses that broken version.

Many of the identity providers have forked this lib at one point or another and now provide vendor-specific experiences. So if you're working with Okta, Microsoft Login, Amazon Cognito, etc you might be better off using their lib since it's customised to their own service and you get official support.

A couple of changes have been in the works since the last release to cater to some of the most common requests. I don't have an ETA when those will ship. I still read most issues as they come in, and plan to address major breaking changes.

Why are there so many issues without an answer? Some items have been answered several times before, are vendor specific or just require a re-read of the integration guide. I do empathize with the devs especially on repeat topics, and plan on addressing some of the shortcomings, but don't want to give false hope on when the next version is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants