Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jetty 9.3.22 #567

Closed
kaikreuzer opened this issue Nov 17, 2017 · 6 comments
Closed

Upgrade to Jetty 9.3.22 #567

kaikreuzer opened this issue Nov 17, 2017 · 6 comments
Labels

Comments

@kaikreuzer
Copy link
Member

Due to eclipse-archived/smarthome#4569 (which fixes eclipse-archived/smarthome#4531), we need to immediately update the Jetty HTTP client to at least version 9.3.15.

Unfortunately, the latest pax-web 6.0.7 release still uses Jetty 9.3.14, so there is no simple way to get a more recent version.

Updating Karaf might help in a way that it defines a "jetty" feature which comes with version 9.3.15 - but this would mean that we have to drop the usage of Pax-Web. I cannot yet fully assess how we can get there and what it exactly means for existing setups.

@kaikreuzer
Copy link
Member Author

@lolodomo FYI, this is required for the Sonos fix.

@lolodomo
Copy link
Contributor

@kaikreuzer : just for a clear understanding and a correct communication, that means the Sonos problem is not yet fixed (even if the issue in ESH is now closed) and still present in the last OH distribution ?
I cannot test the fix even in Eclipse ?

@kaikreuzer
Copy link
Member Author

As summarized here, the fix is to update the Jetty HTTP library and this is what this issue here is about.

@lolodomo
Copy link
Contributor

I understand that we recently moved to Jetty 9.3.14 and JUPnP 2.3 which introduced a problem in the Sonos binding due to a bug in Jetty 9.3.14.
Can you please explain if this bug in Jetty 9.3.14 should impact only bindings using JUPnP or can it impact other bindings too and in this case which kind of bindings ?

@kaikreuzer
Copy link
Member Author

@lolodomo I didn't see any other bindings being hit by the Jetty bug. It seemed to only occur in the massive parallel operation that is done when querying remote UPnP devices for all their services.

@kaikreuzer
Copy link
Member Author

Updating to Jetty 9.3.15 isn't a good choice when using Pax-Web (as done in Karaf), see https://issues.apache.org/jira/plugins/servlet/mobile#issue/KARAF-4990.

I therefore decided to go for the latest patch level 9.3.22 instead, which seems to work well.
Note that I had to force Pax-Web and Karaf to use this version (see #570) as both are still using older versions in their official builds.

@kaikreuzer kaikreuzer changed the title Upgrade to Jetty 9.3.15 Upgrade to Jetty 9.3.22 Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants