Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] AbstractSubscriber class should be designed as interface. #1441

Open
3 tasks done
2084276225 opened this issue Sep 2, 2023 · 0 comments
Open
3 tasks done

Comments

@2084276225
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

public abstract class AbstractSubscriber {

/**
 * Event callback.
 *
 * @param event
 */
public abstract void onEvent(T event);

/**
 * Type of this subscriber's subscription.
 *
 * @return
 */
public abstract Class<? extends AbstractEvent> subscribeType();

/**
 * Executor.
 *
 * @return executor
 */
public Executor executor() {
    return null;
}

}

Describe the solution you'd like

I think this AbstractSubscriber class should be designed as interface,such as Map interface and AbstractMap class

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@yanrongzhen yanrongzhen changed the title I think this AbstractSubscriber class should be designed as interface [Enhancement] AbstractSubscriber class should be designed as interface. Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant