Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: hippo4j config model in zookeeper config before check #1457

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Sep 11, 2023

Fixes #1439

@xjlgod
Copy link
Contributor Author

xjlgod commented Sep 11, 2023

By the way, I think using propertiesClassName to choose check logic in "cn/hippo4j/core/enable/BeforeCheckConfiguration.java" is not a good way. For instance, if the propertiesClassName is set to “SpringBootstrapConfigProperties” will do nothing.

@magestacks
Copy link
Member

@xjlgod Please resolve code conflicts.

@xjlgod
Copy link
Contributor Author

xjlgod commented Sep 16, 2023

@xjlgod Please resolve code conflicts.

I have done it. How about the question I talked.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (f1957dd) 34.53% compared to head (7e1ccea) 34.45%.
Report is 4 commits behind head on develop.

❗ Current head 7e1ccea differs from pull request most recent head 8c9e166. Consider uploading reports for the commit 8c9e166 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1457      +/-   ##
=============================================
- Coverage      34.53%   34.45%   -0.09%     
  Complexity       846      846              
=============================================
  Files            262      262              
  Lines           5904     5918      +14     
  Branches         549      554       +5     
=============================================
  Hits            2039     2039              
- Misses          3672     3686      +14     
  Partials         193      193              
Files Changed Coverage Δ
.../hippo4j/core/enable/BeforeCheckConfiguration.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magestacks magestacks merged commit e98b106 into opengoofy:develop Sep 18, 2023
3 checks passed
@magestacks
Copy link
Member

By the way, I think using propertiesClassName to choose check logic in "cn/hippo4j/core/enable/BeforeCheckConfiguration.java" is not a good way. For instance, if the propertiesClassName is set to “SpringBootstrapConfigProperties” will do nothing.

If there are any problems with the current design, I will deal with them collectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Check the required fields such as the configuration center when the Config mode starts
2 participants