Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Settings in Export / Dataset Manager / Validator #847

Open
signedav opened this issue Nov 23, 2023 · 2 comments
Open

Database Settings in Export / Dataset Manager / Validator #847

signedav opened this issue Nov 23, 2023 · 2 comments

Comments

@signedav
Copy link
Member

signedav commented Nov 23, 2023

The current implementation is like this. When opening...

  • ... Wizard > Export: We see the last used db connection
  • ... Dataset Manager: We see the last used db connection
  • ... Validator: We have (not editable) the db connection of the currently selected layer

image

This behavior is a little confusing. Both ways have pros and cons. Pro on the last used db connection and having it editable is that you don't need to have this schema in the current project. The con is, that you have to set it manually if it does not correspond to your current project.

My thoughts

I like, that we cannot edit the db-connection in the Validator. Because the results points then to the data in the current project so it would be very misleading. So I would not change there anything.

I find it confusing that I open the Dataset Manager or the Wizard > Export and it does not correspond to the schema I have in my current project (what is mostly only one), but it's fine to be able to change them.

Question

What would be the best behavior on Dataset Manager and Wizard Export?

  1. Connection should be taken over automatically from the currently selected layer's datasource
  2. Connection should be taken over on request (means by button) from the currently selected layer's datasource
  3. It's perfect like it is now...
  4. other

Any opinions?

@webrian
Copy link
Contributor

webrian commented Nov 27, 2023

Thanks for raising this issue, some time ago I came across this, too. So in my opinion:

  • Wizard > Export: connection is taken over automatically from the selected layer, but the connection is still editable. So it is still possible to export from another database schema.
  • Dataset Manager: connection is taken over automatically from the selected layer, the connection is not editable. I guess it is not meaningful to edit datasets from a database schema which is not loaded.
  • Validator: leave it as it is.

Just as a side note: it could also be handy to export data directly from the Data Validator panel (with the same settings concerning models, baskets, datasets etc.)

@signedav
Copy link
Member Author

Thanks. I completely agree on your opinion.

I thought that on Dataset Manager one might need another user with more permissions. But in the end it's only creating data - the same what we do on digitizing. So this won't mind I guess.

Just as a side note: it could also be handy to export data directly from the Data Validator panel (with the same settings concerning models, baskets, datasets etc.)

Yes, I can imagine that this would be useful. I'm just a little careful in introducing new options in the validator panel since it's growing quite fast. But the idea is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants