Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept more input formats #51

Open
felix-schott opened this issue Oct 16, 2023 · 2 comments
Open

Accept more input formats #51

felix-schott opened this issue Oct 16, 2023 · 2 comments
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers help wanted Extra attention is needed

Comments

@felix-schott
Copy link
Collaborator

Description

Currently the ob get_buildings utility and the underlying download_buildings.download() function accept a GeoJSON AOI, either as a file or piped from stdin. As WKT is already used under the hood, it makes sense to also accept WKT as an alternative to GeoJSON. It's easy to distinguish between both even when piped in.

Other formats could also be supported, potentially the full range of formats that is supported as output formats.

@felix-schott felix-schott added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed get_buildings Issues related to the get_buildings operations labels Oct 16, 2023
@mtravis
Copy link
Contributor

mtravis commented Oct 16, 2023

I think having the ability to directly pass the WKT is a great idea.

@cholmes
Copy link
Collaborator

cholmes commented Oct 18, 2023

Love it, and more formats would be interesting. Related is #13 (comment) - I think we also need to tighten up what happens if a user passes in a geojson (or other format) with more than one feature. And also what we do if someone puts in a point or a line. Like might be nice to just apply some standard buffer, and also a flag to control buffer size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants