Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to just get the 'count' of buildings, but not actually download the results. #30

Open
cholmes opened this issue Oct 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers
Milestone

Comments

@cholmes
Copy link
Collaborator

cholmes commented Oct 9, 2023

It'd be nice to be able to quickly see how many buildings a request would result in, instead of downloading all the buildings. This can be done by just doing a select count (*) (instead of select *) in DuckDB, and then just printing that out and not downloading anything.

To add this just start with --verbose to see what type of queries DuckDB will issue, and then try out a similar query that will just get the count and make sure it works. Then try just changing the core 'download' command to do a count and print that out. Once that is working then you just need to add the flag, to the cli.py and pass in the count flag to the download function in download_buildings.

If you want to take this on and have more questions feel free to comment here and I can explain more.

@cholmes cholmes added enhancement New feature or request get_buildings Issues related to the get_buildings operations labels Oct 9, 2023
@cholmes cholmes added this to the 0.10.0 milestone Oct 9, 2023
@cholmes cholmes added the good first issue Good for newcomers label Oct 9, 2023
@mtravis
Copy link
Contributor

mtravis commented Oct 9, 2023

@cholmes happy to take this one on.

@cholmes
Copy link
Collaborator Author

cholmes commented Oct 9, 2023

Go for it! Just make a PR and I can review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants