Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over attributes requested in get-buildings #28

Open
cholmes opened this issue Oct 9, 2023 · 0 comments
Open

Control over attributes requested in get-buildings #28

cholmes opened this issue Oct 9, 2023 · 0 comments
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers

Comments

@cholmes
Copy link
Collaborator

cholmes commented Oct 9, 2023

Right now the get-buildings call just requests all attributes. It'd be nice if we had --include and --exclude flags like tippecanoe does, to give users more control over the attributes they want.

To tackle this issue the get_buildings command in cli.py should have two more flags added, and then download_buildings should get them in. Then the select_values variable should be tweaked with the right logic. Can leverage DuckDB's exclude command to form the sql, and the include would just pass the values in. It'd likely make sense to just not allow a user to use both include and exclude, as that'd be funky logic to get right.

@cholmes cholmes added enhancement New feature or request good first issue Good for newcomers get_buildings Issues related to the get_buildings operations labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request get_buildings Issues related to the get_buildings operations good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant