Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs are unclear for - how to change a theme? #70

Open
amitbend opened this issue Nov 3, 2018 · 1 comment
Open

Docs are unclear for - how to change a theme? #70

amitbend opened this issue Nov 3, 2018 · 1 comment

Comments

@amitbend
Copy link

amitbend commented Nov 3, 2018

Thanks for this repo!
I'm on the process of developing a theme and I'm not sure how to add it to the docker images so it will be hot reloaded.

after running
$ make clone $ make dev-assets
I need to activate the theme and run make dev-watch.
The process of activation is not clear, as in devstack I would ssh into the docker machine, clone the repo and change the lms.env.json file etc.
From digging into the repo I've found a script bin/watch which is looking for a variable called THEME but it's unclear if this script is running and when + where should I clone my repo into?

@jmaupetit jmaupetit self-assigned this Nov 6, 2018
@jmaupetit
Copy link
Contributor

Hey @amitbend! Thanks again for your report. As mentioned in #67, this feature is not fully implemented yet, but be sure that it is on our roadmap! I will declare a new issue to describe this feature, i.e. our expectations and the way it needs to be implemented, so that it would be easy for people apart from FUN to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants