Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default args in Dockerfile #201

Open
lunika opened this issue Feb 21, 2020 · 1 comment
Open

Remove default args in Dockerfile #201

lunika opened this issue Feb 21, 2020 · 1 comment

Comments

@lunika
Copy link
Member

lunika commented Feb 21, 2020

Purpose

Every Dockerfile define a default EDX_RELEASE_REF and EDX_ARCHIVE_URL argument. Every time we want to use a new release, we have to update the corresponding Dockerfile.

Proposal

We should remove the default value and explicitly use build arguments in our Makefile.

@lunika lunika mentioned this issue Feb 21, 2020
2 tasks
@jmaupetit
Copy link
Contributor

jmaupetit commented Feb 21, 2020

Build arguments that come from our active environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants