Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller images for crop page #3610

Open
monsieurtanuki opened this issue Jan 21, 2023 · 5 comments
Open

Smaller images for crop page #3610

monsieurtanuki opened this issue Jan 21, 2023 · 5 comments

Comments

@monsieurtanuki
Copy link
Contributor

Problem

Currently, when the user wants to edit a picture, first we download the full version of the picture, and then we go to the crop page.
That is visible for the user, and that demands internet.
I believe the reason for that is that the previous crop tool zoomed the picture on the fly, like if you decide to make a small crop area, the image was zoomed so that the small crop area is displayed full screen. That's why we needed the best resolution: to get correct display when zoomed.
But we don't zoom anymore when we crop, with the new crop tool, we keep the full picture full screen.

Proposed solution

Perhaps we don't need the full picture and we would be better off with the 400 picture, at least on some devices - and perhaps for all of them. That would save us an annoying download step, and may make it possible to replace pictures when offline (no internet needed before taking the picture).

@monsieurtanuki monsieurtanuki added the ✨ enhancement New feature or request label Jan 21, 2023
@BhuvanAde
Copy link
Contributor

Can I work on this issue?

@monsieurtanuki
Copy link
Contributor Author

Hi @BhuvanAde!

For the moment it is just an idea, that hasn't met a lot of interest, functionally-wise.
Besides, I'm currently working on other more important issues on the same topic (#766 #2427), which may impact this issue and even its relevancy. Therefore we should put this issue on the shelf, at least code-wise.

Are there specific topics (technical or functional) you would like to work on?

@BhuvanAde
Copy link
Contributor

I'm open for either of them.

@monsieurtanuki
Copy link
Contributor Author

@BhuvanAde Oh I meant I'm already working on those issues, and even closed one of them. I'm currently dealing with those product image new pages myself.

Following are other issues I planned to work on but haven't started yet, and that you may find interesting:

@BhuvanAde
Copy link
Contributor

Thanks @monsieurtanuki I would love to start work on #3615 and #2427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants