Towards systematic mockups and visual signoff before coding

[teolemon]

I think it would be good to move again towards systematic mockups and visual signoff before coding, just like we did last spring.
More mockups, and less text which leads to ambiguity.
What do you think ?

[monsieurtanuki]

Mockups can be useful if they help pre-visualizing a page, and make obvious what is missing - or how great the new features are going to be.
But that's a pain in the neck if it's about pre-processing the perfect UI and discuss again and again about the button sizes or colors.

@teolemon If we take #3402, you finally didn't like my suggested UI, and you requested changes. Fair enough. But the PR was about adding the new "camera" button: that was the important part.
Adding labels to buttons, putting buttons on top or on bottom, bigger buttons, is just an extra layer to be applied afterwards. As long as you have the features coded, you can do what you want.

The mockups would rather be:

we need a page about a product image, with features A, B and C immediately accessible
here is a suggested UI - don't put too much effort respecting it, we'll refine it later, as long as the features are there and accessible

[teolemon]

• On feat: 3332 - refactored the new crop page UI and added a camera #3402, I honestly gave up on the very long thread.
  Simplify adding photos by removing 2 of the 4 steps #3332
• I have proposed the mockups based on V1 (Improve the Photo Manager using new features from openfoodfacts-dart #766), but they were never discussed on.
• Said previous suggestions have been refined/polished/battle-tested in version 1 of the app (they do not come from nowhere) , I took the trouble of taking videos (Photo behavior in v1 #3338) (The app is still installable by the way - either on F-Droid or Open Beauty Facts )
• I do not believe you can properly design and iterate on complex and sometimes subtle UI with motion and interactions in discussion threads. You need audio, video, real interactions.

[monsieurtanuki]

@teolemon Of course that's another story if there's already an app and an already discussed UI with actual user feedbacks about version 1.

About implementing the mockups based on V1, the thing is that there are features that are not available yet on off-dart, and I haven't seen a high priority tag on related issues either.

Besides, I prefer to implement features step by step - #3402 was about adding a "camera" button on the crop page - because it's easier to code AND to review.
I did implement #3018 in one PR but it was too big for my reviewers (and tbh even for me re-reading it) and finally had to split #3018 in 7 incremental PRs. One additional month spent splitting the PR in 7. Therefore if I can code simple code in simple PRs that can easily and quickly be reviewed, I'm for it.