Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code base refactoring #338

Open
1 of 4 tasks
M123-dev opened this issue Dec 20, 2021 · 1 comment
Open
1 of 4 tasks

Code base refactoring #338

M123-dev opened this issue Dec 20, 2021 · 1 comment

Comments

@M123-dev
Copy link
Member

M123-dev commented Dec 20, 2021

Tracked in

https://github.com/openfoodfacts/openfoodfacts-dart/projects/2

Why

The code of the sdk has grown a lot lately and will probably continue to do so, albeit at a slower pace. To keep the code maintainable a few things will probably have to be changed. The things mentioned here are not decided, only ideas and are open for discussion.

What

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Dec 20, 2021

To me the biggest issue is with #291. I can add fields to Product but I don't know what they're here for, the typical values, what's their unit (if applicable), if they work in READ, in WRITE (#331 (comment)), if they are impacted by the states tags (cf. #326). Comments on each field would help, at least in a first approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants