feat: #304 - new method setProductImageAngle #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleted file: * `corn_da.jpg` Impacted files: * `api_addProductImage_test.dart`: added a test for `OpenFoodAPIClient.setProductImageAngle`; removed a duplicate test * `JsonHelper.dart`: decoded new fields `imgid` and `angle` for product `'images`'' * `openfoodfacts.dart`: new method `setProductImageAngle` * `ProductImage.dart`: added `enum ImageAngle`; added `imgid` and `angle` to `ProductImage` * `UriHelper.dart`: unrelated refactoring
Impacted files: * `api_addProductImage_test.dart`: added a test for `OpenFoodAPIClient.setProductImageCrop`; minor refactoring * `ImageHelper.dart`: added methods `getProductImageRootUrl` and `getProductImageFilename`; minor refactoring * `JsonHelper.dart`: populated crop fields of `ProductImage` for product `'images'`; minor refactoring * `openfoodfacts.dart`: added method `setProductImageCrop`; minor refactoring * `ProductHelper.dart`: minor refactoring * `ProductImage.dart`: added crop fields `coordinatesImageSize`, `x1`, `y1`, `x2` and `y2` to `ProductImage`
M123-dev
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Thanks @monsieurtanuki, I have nothing major to put out, but please have a look at my comments
lib/model/ProductImage.dart
Outdated
|
|
||
| String get degreesClockwise => _DEGREES_CLOCKWISE[this]?.toString() ?? '0'; | ||
|
|
||
| static ImageAngle? fromInt(final int? angle) { |
There was a problem hiding this comment.
Maybe a comment here that it only allow 0, 90, 170 and 270
| image.rev.toString() + | ||
| '.' + | ||
| image.size.toNumber() + | ||
| '.jpg'; |
There was a problem hiding this comment.
Does the server allow other types then .jpg
Impacted file: * `ProductImage.dart`
|
Thank you @M123-dev for your code review! Yes it's always |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted file:
corn_da.jpgImpacted files:
api_addProductImage_test.dart: added a test forOpenFoodAPIClient.setProductImageAngle; removed a duplicate testJsonHelper.dart: decoded new fieldsimgidandanglefor product'images'openfoodfacts.dart: new methodsetProductImageAngleProductImage.dart: addedenum ImageAngle; addedimgidandangletoProductImageUriHelper.dart: unrelated refactoring