Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server-side crop a photo #305

Closed
Tracked by #218
teolemon opened this issue Nov 29, 2021 · 7 comments · Fixed by #309
Closed
Tracked by #218

Add server-side crop a photo #305

teolemon opened this issue Nov 29, 2021 · 7 comments · Fixed by #309
Assignees
@monsieurtanuki
Labels
🖼️ Photo management

Comments

@teolemon
Copy link
Member

teolemon commented Nov 29, 2021 •
edited

What

Part of
@teolemon teolemon mentioned this issue Nov 29, 2021
Open
@teolemon teolemon changed the title Server-side crop a photo https://openfoodfacts.github.io/api-documentation/#jump-4WRITERequests-Cropaphoto Add server-side crop a photo Nov 29, 2021
@monsieurtanuki
Copy link
Contributor

@teolemon What is imgid?
Capture d’écran 2021-12-04 à 16 15 04

@monsieurtanuki monsieurtanuki mentioned this issue Dec 4, 2021
Closed
@teolemon
Copy link
Member Author

teolemon commented Dec 4, 2021 •
edited

imgid you can find in the request, it's a unique id assigned to uploaded images, regardless of whether they are selected or not. You apply a rotation to a raw image id, and you place it in id like front_fr (which is a selection)
https://world.openfoodfacts.org/api/v0/product/3017620422003.json?fields=images

https://world.openfoodfacts.org/product/3760284870115/tiramisu-patissier
https://world.openfoodfacts.org/images/products/376/028/487/0115/1.jpg (1 is imgid)
https://world.openfoodfacts.org/images/products/376/028/487/0115/front_fr.8.full.jpg (front_fr is id, the 8 gets assigned automatically)

@monsieurtanuki monsieurtanuki self-assigned this Dec 4, 2021
@monsieurtanuki
Copy link
Contributor

There's probably something wrong in product_image_crop.pl, or in the way I expect the parameters to work:

What's wrong?

@teolemon
Copy link
Member Author

teolemon commented Dec 6, 2021 •
edited

If you want to crop again an already cropped image like you do you need to start from the source image, get the current cropping coords if you want to expose them to the user, and apply the new crop coords to the original image (1.jpg)

@monsieurtanuki
Copy link
Contributor

I've tried from scratch on an existing product that did not have a front_de image.

Btw how would I get the current cropping coords?

@teolemon
Copy link
Member Author

teolemon commented Dec 6, 2021 •
edited

https://world.openfoodfacts.net/cgi/product_image_crop.pl?code=3017620422003&id=1&imgid=front_fr&imgid=108&x1=10&y1=10&x2=800&y2=500
you set image 1 with given coords as front_fr

monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Dec 7, 2021
@monsieurtanuki
feat: openfoodfacts#305 - new method setProductImageCrop
a033813 
Impacted files:
* `api_addProductImage_test.dart`: added a test for `OpenFoodAPIClient.setProductImageCrop`; minor refactoring
* `ImageHelper.dart`: added methods `getProductImageRootUrl` and `getProductImageFilename`; minor refactoring
* `JsonHelper.dart`: populated crop fields of `ProductImage` for product `'images'`; minor refactoring
* `openfoodfacts.dart`: added method `setProductImageCrop`; minor refactoring
* `ProductHelper.dart`: minor refactoring
* `ProductImage.dart`: added crop fields `coordinatesImageSize`, `x1`, `y1`, `x2` and `y2` to `ProductImage`
@monsieurtanuki monsieurtanuki linked a pull request Dec 7, 2021 that will close this issue
feat: #304 - new method setProductImageAngle #309
Merged
@monsieurtanuki
Copy link
Contributor

I found out what was missing: query parameter coordinates_image_size=full. With that parameter the crop coordinates are on the full uploaded image, not its "400-max" version.
I've just committed a code that works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🖼️ Photo management
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #304 - new method setProductImageAngle monsieurtanuki/openfoodfacts-dart
2 participants
@teolemon @monsieurtanuki