Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #301 - new method getProductUri #302

Merged
merged 2 commits into from Dec 4, 2021

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • api_getProduct_test.dart: new test "get product uri"
  • CountryHelper.dart: replaced 'gb' with the OFF standard 'uk'
  • openfoodfacts.dart: new method getProductUri
  • UriHelper.dart: new method replaceSubdomain

Impacted files:
* `api_getProduct_test.dart`: new test "get product uri"
* `CountryHelper.dart`: replaced 'gb' with the OFF standard 'uk'
* `openfoodfacts.dart`: new method `getProductUri`
* `UriHelper.dart`: new method `replaceSubdomain`
Impacted file:
* `api_saveProduct_test.dart`: clearer test
@monsieurtanuki
Copy link
Contributor Author

@M123-dev ping

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monsieurtanuki, the code looks good and sorry I have lost a bit sight of this PR

@monsieurtanuki monsieurtanuki merged commit 85169f0 into openfoodfacts:master Dec 4, 2021
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev!

@monsieurtanuki monsieurtanuki linked an issue Dec 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get localized Open Food Facts product URI
2 participants