Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to latest KnowledgePanel API changes #294

Merged
merged 45 commits into from Nov 16, 2021

Conversation

jasmeet0817
Copy link
Contributor

No description provided.

@M123-dev
Copy link
Member

M123-dev commented Nov 16, 2021

We now create the release with release please, in order for it to add the commit messages to the changelog they need a certain scheme. It would be good if you could add the prefix when merging the PR. After pressing merge you should be able to change the name.

It would be either
feat: ...
or
fix: ...
and more but I am not sure which are supported.

For breaking changes a ! does the trick (fix!:) but since the KnowledgePanels are very beta it's probably fine without marking it as breaking.

@jasmeet0817 jasmeet0817 changed the title Update to latest KnowledgePanel API changes fix: Update to latest KnowledgePanel API changes Nov 16, 2021
@JsonValue('neutral')
NEUTRAL,
@JsonValue('average')
AVERAGE,
@JsonValue('bad')
BAD,
UNKNOWN,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no @JsonValue('unknown') ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more value is "neutral" if I remember correctly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right: environment/packaging_recycling.tt.json: "evaluation": "neutral",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between "average" and "neutral"? Can't we collapse them into one ?

Unknown: the object gets a value of enum type UNKNOWN when the json parser encounters a value from the server that isn't mappable to anything else in this enum (specifically if server responds with something other than Good, bad, average, the variable is assigned UNKNOWN).

@peterwvj
Copy link
Collaborator

Thanks.

@jasmeet0817 please branch off master before working on your changes. This way we can away cluttering the PR with old commits.

@jasmeet0817
Copy link
Contributor Author

Thanks.

@jasmeet0817 please branch off master before working on your changes. This way we can away cluttering the PR with old commits.

Sure thing

Jasmeet Singh added 2 commits November 16, 2021 16:40
@jasmeet0817 jasmeet0817 merged commit 5163db5 into openfoodfacts:master Nov 16, 2021
jasmeet0817 pushed a commit to jasmeet0817/openfoodfacts-dart that referenced this pull request Nov 16, 2021
jasmeet0817 pushed a commit to jasmeet0817/openfoodfacts-dart that referenced this pull request Nov 16, 2021
jasmeet0817 added a commit that referenced this pull request Nov 16, 2021
Co-authored-by: Jasmeet Singh <jasmeetsingh@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants