Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When no further fragment is visible, the app should close itself #4322

Merged
merged 1 commit into from Oct 24, 2021
Merged

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Oct 24, 2021

When no further fragment is visible on the homescreen, the app should close itself, not recreating an Activity (infinite loop otherwise)

… recreating it (infinite loop otherwise)

Issue #4320
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon requested a review from VaiTon October 24, 2021 09:11
@teolemon teolemon linked an issue Oct 24, 2021 that may be closed by this pull request
@teolemon teolemon added the home Ideas and changes proposed for the application home label Oct 24, 2021
@teolemon teolemon changed the title When no further fragment is visible, the app should close itself fix: When no further fragment is visible, the app should close itself Oct 24, 2021
@teolemon
Copy link
Member

Fail is unrelated: remote: Permission to openfoodfacts/openfoodfacts-androidapp.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/openfoodfacts/openfoodfacts-androidapp.git/': The requested URL returned error: 403
Running post deployment cleanup jobs… 🗑️

@VaiTon VaiTon merged commit 8ae0954 into openfoodfacts:develop Oct 24, 2021
@VaiTon
Copy link
Member

VaiTon commented Oct 24, 2021

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
home Ideas and changes proposed for the application home
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The back button is not working on the homepage
3 participants