Fix NPE in refreshProductCount on HomeFragment #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivekook
commented
Sep 15, 2021
| lifecycleScope.launch { | ||
| val resp = try { | ||
| withContext(Dispatchers.IO) { productsApi.getTotalProductCount(getUserAgent()) } | ||
| lifecycleScope.launchWhenResumed { |
There was a problem hiding this comment.
main fix
based on log "at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)" I can assume, that the coroutine resumed the work while binding is still not inflated
naivekook
commented
Sep 15, 2021
| if (_binding == null) { | ||
| Log.w(LOG_TAG, "setProductCount() calls with null binding") | ||
| } | ||
| _binding?.textHome?.text = if (count == 0) { |
There was a problem hiding this comment.
just in case if binding is still null at this moment
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
approved these changes
Sep 15, 2021
VaiTon
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NPE in refreshProductCount on HomeFragment.
Related issues
#4234