Fix editing in allergens alert screen (closes #4133) #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivekook
added
the
allergens
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
changed the title
|
|
@teolemon don't think so, looks like 4120 is about database migration |
|
@naivekook what do you think about moving data to a new ViewModel? |
|
@VaiTon my intention was just to fix the issue in this PR |
|
@naivekook would you prefer that we first merge this or that we merge the viewmodel version? |
|
@VaiTon sounds good, let's merge this one and next PR will be with refactoring |
VaiTon
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix editing in allergens alert screen
Related issues
Screenshots
https://drive.google.com/file/d/1lw_1sepfjiuCkEbCzXrZ8ewablqjOZCS/view?usp=sharing