Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not working language selection #4192

Merged
merged 5 commits into from Aug 29, 2021

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Aug 27, 2021

Also a general refactor to use kotlin inline for building things.

Closes #3540.
Closes #3437.

Tasks:

Test APK

https://github.com/openfoodfacts/openfoodfacts-androidapp/suites/3615337385/artifacts/87373606

fix: not working language selection
@teolemon
Copy link
Member

@VaiTon just tested the build, it works. Nice touch with the icon 👍

@teolemon
Copy link
Member

@teolemon
Copy link
Member

Also closes #3437

@teolemon teolemon linked an issue Aug 27, 2021 that may be closed by this pull request
3 tasks
@teolemon
Copy link
Member

Not sure if the issue was introduced in this PR, but I spotted that. The photo is not uploaded, and no animation
https://user-images.githubusercontent.com/1689815/131176570-2a029f06-891f-4939-aab2-ea7a6485ff60.mp4

@VaiTon
Copy link
Member Author

VaiTon commented Aug 27, 2021

Not sure if the issue was introduced in this PR, but I spotted that. The photo is not uploaded, and no animation
https://user-images.githubusercontent.com/1689815/131176570-2a029f06-891f-4939-aab2-ea7a6485ff60.mp4

Try to re-scan the product

@VaiTon
Copy link
Member Author

VaiTon commented Aug 27, 2021

I found this one, just after login: https://sentry.io/organizations/openfoodfacts/issues/2608035872/?project=5276851&query=is%3Aunresolved

Idk what's causing this. Investigating right now

@teolemon
Copy link
Member

It pretends to have uploaded the image, but nothing, not even the first one this time :-/

@teolemon
Copy link
Member

I found this one in the branch as well. Not sure if related to your changes: #4196. Happens on trying to edit a product

@teolemon
Copy link
Member

@teolemon
Copy link
Member

@VaiTon LGTM 👍 ✅

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@VaiTon VaiTon merged commit 7caa086 into openfoodfacts:develop Aug 29, 2021
@VaiTon VaiTon deleted the fix/language-change branch August 29, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants