Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix product сomparison #4177

Merged
merged 1 commit into from Aug 24, 2021

Conversation

naivekook
Copy link
Contributor

Description

For some reason, transformations on live data didn't work. Changed it to a simple function with coroutines.
This is the first part with hotfix just to unblock the release. I'm going to prepare the second part with replacing livedata to coroutine flow.

Related issues

#4151

@naivekook naivekook requested a review from VaiTon August 24, 2021 08:06
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon linked an issue Aug 24, 2021 that may be closed by this pull request
@VaiTon VaiTon merged commit 76e189e into openfoodfacts:develop Aug 24, 2021
@naivekook naivekook deleted the vt/fix-product-comparison branch August 24, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compare mode crashes after 1st scan
3 participants