fix: refactored measurements inner working. #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: use extension functions to query db Closes #4145
teolemon
added
editing
naivekook
reviewed
Aug 23, 2021
...c/main/java/openfoodfacts/github/scrachx/openfood/features/adapters/NutrimentsGridAdapter.kt
Show resolved
Hide resolved
...c/main/java/openfoodfacts/github/scrachx/openfood/features/adapters/NutrimentsGridAdapter.kt
Show resolved
Hide resolved
...main/java/openfoodfacts/github/scrachx/openfood/features/additives/AdditiveFragmentHelper.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: naivekook <tanakov.dev@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored inner workings for how we get/treat/send measurement (nutrition values).
Refactored code to convert measurements and to interact with them.
Use extension functions to query the db.
Closes #4145
Tasks