Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AllergenTest #4146

Merged
merged 1 commit into from Aug 9, 2021
Merged

Fix AllergenTest #4146

merged 1 commit into from Aug 9, 2021

Conversation

naivekook
Copy link
Contributor

Fix allergen test

Related issues

#4139

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon requested a review from VaiTon August 9, 2021 06:45
teolemon
teolemon reviewed Aug 9, 2021
View reviewed changes
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did we change for the German allergen to break ?

@teolemon teolemon added the allergens Relating to allergen display or detection in food products label Aug 9, 2021
@naivekook
Copy link
Contributor Author

naivekook commented Aug 9, 2021 •
edited

It is a good question, from a test perspective looks like sort function in object parsing was changed

@VaiTon VaiTon merged commit ccd5da9 into openfoodfacts:develop Aug 9, 2021
@naivekook naivekook deleted the vt/fix-allergen-test branch August 9, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon left review comments

@VaiTon VaiTon VaiTon approved these changes

Assignees
No one assigned
Labels
allergens Relating to allergen display or detection in food products
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naivekook @teolemon @VaiTon