Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: confirmation added when setting a photo from the photos tab #3870

Merged
merged 1 commit into from Mar 8, 2021

Conversation

kartikaysharma01
Copy link
Contributor

Description

Added a toast to let user know the image is set

Related issues

Fixes #3832

Screenshots

image

@teolemon teolemon changed the title confirmation added when setting a photo from the photos tab FEAT: confirmation added when setting a photo from the photos tab Mar 6, 2021
@teolemon teolemon requested a review from a team March 6, 2021 09:44
@VaiTon
Copy link
Member

VaiTon commented Mar 6, 2021

As Android Docs recommends, I'd like to use snackbar for this.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartikaysharma01
Copy link
Contributor Author

kartikaysharma01 commented Mar 8, 2021

@VaiTon made the changes

image

@VaiTon VaiTon merged commit ae3498f into openfoodfacts:develop Mar 8, 2021
@VaiTon
Copy link
Member

VaiTon commented Mar 8, 2021

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a confirmation when setting a photo from the photos tab
3 participants