imageurl made nullable (NPE fixed)

[kartikaysharma01]

Description

imageurl made nullable

Related issues

Fixes #3852
Fixes #3843

[VaiTon]

I don't like how we're fixing this. I'd like to keep nullable values out of the DB so let's so as on line

openfoodfacts-androidapp/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/summary/SummaryProductFragment.kt

Line 812 in 17a4c46

productName.orEmpty(),

and just pass an empty value there.

[kartikaysharma01]

I don't like how we're fixing this. I'd like to keep nullable values out of the DB so let's so as on line
and just pass an empty value there.

@VaiTon That was my first instinct too. But the Picasso library we are using does not allow empty or blank strings while loading image url.

[VaiTon]

I don't like how we're fixing this. I'd like to keep nullable values out of the DB so let's so as on line
and just pass an empty value there.

@VaiTon That was my first instinct too. But the Picasso library we are using does not allow empty or blank strings while loading image url.

And does it allow null values? We could check if the string is empty where we need to use it.

[kartikaysharma01]

And does it allow null values?

@VaiTon Yes, it handles null values gracefully ( skips loading and sets image as placeholder )

We could check if the string is empty where we need to use it.

Yes that can be done

[kartikaysharma01]

@VaiTon comments resolved

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[VaiTon]

Thanks a lot! 🎉