fix: don't replace fragment on another fragment if they are the same

[naivekook]

Description

when user clicks on "Home" button twice we did a replacement of current fragment on new instance of this fragment and do extra calls to the server

Related issues

Fixes #3465

[naivekook]

@VaiTon @teolemon please take a look

[VaiTon]

I don't really like this implementation using tag string. Can't we compare using is, for example? Is there a way to get the actual displayed fragment?

[naivekook]

I don't really like this implementation using tag string.

Can I ask you why?

fragment manager doesn't have convenient mechanism to retrieve current fragment, by combining findFragmentByTag and fragment.isVisible we can understand this

looks like we use replace everywhere without backstack so we have only one fragment attached, in this case I can do next thing and it will work too

with((currentActivity as FragmentActivity).supportFragmentManager) {
                        val fragment = fragments.lastOrNull()
                        if (fragment == null || fragment !is HomeFragment) {
                            commit {
                                replace(R.id.fragment_container, HomeFragment.newInstance(), HomeFragment.TAG)
                                addToBackStack(null)
                            }
                        }
                    }

[VaiTon]

I don't really like this implementation using tag string.

Can I ask you why?

Just because it's a useless var if we can check the type as you showed IMHO.

About your second solution, if you could test it and see if it works it would be awesome!

[naivekook]

@VaiTon hey check updated version please
I've been tested it on emulator and it works

[naivekook]

ptal @VaiTon

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[VaiTon]

Thanks! 🎉