Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed layout issue on some attributes with long text #3727

Merged
merged 1 commit into from Feb 14, 2021

Conversation

varunvjha
Copy link
Contributor

Description

I added a bottom margin to the seperator.

Related issues

Fixes #3724

@VaiTon
Copy link
Member

VaiTon commented Jan 13, 2021

I'm sorry but you can't fix this by only putting a margin as the height of the element is fixed. Instead you should make the height 0dp and then fix the margins.

Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon
Copy link
Member

@VaiTon is it fixed by the other PR ?

@VaiTon
Copy link
Member

VaiTon commented Jan 29, 2021

@VaiTon is it fixed by the other PR ?

Which one?

@teolemon
Copy link
Member

@VaiTon I dreamt it :-)

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VaiTon VaiTon merged commit 101989f into openfoodfacts:develop Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout issue on some attributes with long text
3 participants