Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to refresh the history (causes big Nutri-Score problem) #3162

Closed
teolemon opened this issue May 22, 2020 · 4 comments · Fixed by #3840
Closed

Make it possible to refresh the history (causes big Nutri-Score problem) #3162

teolemon opened this issue May 22, 2020 · 4 comments · Fixed by #3840
Assignees
Labels
history The use and exporting of history within the application P1

Comments

@teolemon
Copy link
Member

Make it possible to refresh the history on pull down.
A number of values are currently stored in the History, and not refreshed, including

  • the product name
  • image
  • Nutri-Score.
    We got reports of users complaining the Nutri-Score was not the right one as a result, that the photos were not up-to-date…
    We need to set up a refresh mechanism (on pull to refresh ?) so that we can have an up-to-date history. This includes altering the entries, and fetching the new values using the API
@teolemon teolemon added history The use and exporting of history within the application P1 labels May 22, 2020
@teolemon teolemon changed the title Make it possible to refresh the history Make it possible to refresh the history (causes big Nutri-Score problem) May 22, 2020
@VaiTon
Copy link
Member

VaiTon commented May 22, 2020

At the moment the scroll mechanism is very "spaghetti code". Everything is on BaseActivity I think.

I will investigate and update here.

@naivekook
Copy link
Contributor

Is it still actual?

@VaiTon
Copy link
Member

VaiTon commented Feb 3, 2021

I think it is. We store history products in the db when we scan them/we open them. The app doesn't refresh them when swiping down on the history screen, it just re-queries the db. So yes, it is actual. @naivekook

@naivekook
Copy link
Contributor

@VaiTon I can take it
as I understand correct on screen created and pull-to-refresh events I need to get all items from db, perform an API call getProductByBarcode, update database and show the info to the user?
is it ok if will make a refactoring of screen? I want to move logic from activity to viewmodel class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
history The use and exporting of history within the application P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants