From d1d0f81fac23da98afe4620c8bd8fef0983b909a Mon Sep 17 00:00:00 2001 From: VaiTon Date: Sat, 3 Jul 2021 11:50:55 +0200 Subject: [PATCH] fix: add sentry reporting if URI in null when saving file in ScanHistoryActivity --- .../features/scanhistory/ScanHistoryActivity.kt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/scanhistory/ScanHistoryActivity.kt b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/scanhistory/ScanHistoryActivity.kt index 3035229e6977..eab7a4ae3368 100644 --- a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/scanhistory/ScanHistoryActivity.kt +++ b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/scanhistory/ScanHistoryActivity.kt @@ -10,6 +10,7 @@ import android.os.Build import android.os.Bundle import android.os.Environment import android.provider.Settings +import android.util.Log import android.view.Menu import android.view.MenuItem import android.widget.Toast @@ -33,6 +34,7 @@ import openfoodfacts.github.scrachx.openfood.AppFlavors.OFF import openfoodfacts.github.scrachx.openfood.AppFlavors.isFlavors import openfoodfacts.github.scrachx.openfood.BuildConfig import openfoodfacts.github.scrachx.openfood.R +import openfoodfacts.github.scrachx.openfood.analytics.SentryAnalytics import openfoodfacts.github.scrachx.openfood.databinding.ActivityHistoryScanBinding import openfoodfacts.github.scrachx.openfood.features.listeners.CommonBottomListenerInstaller.installBottomNavigation import openfoodfacts.github.scrachx.openfood.features.listeners.CommonBottomListenerInstaller.selectNavigationItem @@ -43,6 +45,7 @@ import openfoodfacts.github.scrachx.openfood.network.OpenFoodAPIClient import openfoodfacts.github.scrachx.openfood.utils.* import openfoodfacts.github.scrachx.openfood.utils.SortType.* import java.io.File +import java.io.IOException import java.text.SimpleDateFormat import java.util.* import javax.inject.Inject @@ -96,9 +99,17 @@ class ScanHistoryActivity : BaseActivity() { } } + @Inject + lateinit var sentryAnalytics: SentryAnalytics + @RequiresApi(Build.VERSION_CODES.KITKAT) val fileWriterLauncher = registerForActivityResult(CreateCSVContract()) { - writeHistoryToFile(this, adapter.products, it) + if (it == null) { + Log.w(LOG_TAG, "Could not write to file.") + sentryAnalytics.record(IOException("Could not write to file.")) + } else { + writeHistoryToFile(this, adapter.products, it) + } } override fun onCreate(savedInstanceState: Bundle?) {