From 87b4bd78c9a36ec2466d437f2288af64ba3150fb Mon Sep 17 00:00:00 2001 From: Kartikay Sharma Date: Thu, 4 Mar 2021 03:50:21 +0530 Subject: [PATCH] fix: NPE when image url is not given (#3863) --- .../features/product/view/summary/SummaryProductFragment.kt | 2 +- .../scrachx/openfood/features/productlist/ProductListAdapter.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/summary/SummaryProductFragment.kt b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/summary/SummaryProductFragment.kt index b01a51aa0c3e..bd06baf2c35b 100644 --- a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/summary/SummaryProductFragment.kt +++ b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/product/view/summary/SummaryProductFragment.kt @@ -811,7 +811,7 @@ class SummaryProductFragment : BaseFragment(), ISummaryProductPresenter.View { productBarcode, productName.orEmpty(), productDetails, - imageUrl!! + imageUrl.orEmpty() ) addToListRecyclerView.layoutManager = LinearLayoutManager(activity) addToListRecyclerView.adapter = addToListAdapter diff --git a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListAdapter.kt b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListAdapter.kt index b0e828413ab1..5568af44113d 100644 --- a/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListAdapter.kt +++ b/app/src/main/java/openfoodfacts/github/scrachx/openfood/features/productlist/ProductListAdapter.kt @@ -35,7 +35,7 @@ class ProductListAdapter( holder.tvDetails.text = products[position].productDetails holder.tvBarcode.text = products[position].barcode - if (!isLowBatteryMode) { + if (!isLowBatteryMode && products[position].imageUrl.isNotEmpty()) { Picasso.get() .load(products[position].imageUrl) .placeholder(R.drawable.placeholder_thumb)