Improve AuthorizationModelResolutionTooComplex error

[miparnisari]

Checklist

• I agree to the terms within the OpenFGA Code of Conduct.

Describe the problem you'd like to have solved

if errors.Is(err, graph.ErrResolutionDepthExceeded) || errors.Is(err, graph.ErrCycleDetected) {

appears in three different locations in the codebase today.

1. openfga/pkg/server/commands/list_objects.go

   Lines 318 to 321 in a0cd000

   	if errors.Is(err, graph.ErrResolutionDepthExceeded) || errors.Is(err, graph.ErrCycleDetected) {
   	resultsChan <- ListObjectsResult{Err: serverErrors.AuthorizationModelResolutionTooComplex}
   	return
   	}

2. openfga/pkg/server/commands/list_objects.go

   Lines 334 to 336 in a0cd000

   	if errors.Is(err, graph.ErrResolutionDepthExceeded) || errors.Is(err, graph.ErrCycleDetected) {
   	err = serverErrors.AuthorizationModelResolutionTooComplex
   	}

3. openfga/pkg/server/server.go

   Lines 653 to 655 in 4fd659e

   	if errors.Is(err, graph.ErrResolutionDepthExceeded) || errors.Is(err, graph.ErrCycleDetected) {
   	return nil, serverErrors.AuthorizationModelResolutionTooComplex
   	}

And I suppose we will need to have it also for the future ListUsers API.

Describe the ideal solution

Remove the code duplication. We can keep AuthorizationModelResolutionTooComplex, remove the others, and update AuthorizationModelResolutionTooComplex to hold the actual cause of the error 🤔

Alternatives and current workarounds

No response

Additional context

No response

[github-actions]

It appears this issue has been stale for at least 14 days 🗓️. If no action is taken the maintainer team may consider closing the issue. Please reach out if you need feedback or follow up actions from the maintainer team.