Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude mock_check_resolver from code coverage #1398

Closed
1 task done
miparnisari opened this issue Feb 26, 2024 · 1 comment
Closed
1 task done

Exclude mock_check_resolver from code coverage #1398

miparnisari opened this issue Feb 26, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers Stale

Comments

@miparnisari
Copy link
Member

Checklist

Describe the problem you'd like to have solved

https://app.codecov.io/gh/openfga/openfga/blob/main/internal%2Fgraph%2Fmock_check_resolver.go

internal/graph/mock_check_resolver.go has 71.43% coverage.

Describe the ideal solution

Two options:

  1. Call Close() on the MockCheckResolver whenever it's used to bring coverage up, or
  2. Exclude this file from code coverage.

Or both :)

Alternatives and current workarounds

No response

Additional context

No response

@miparnisari miparnisari added the good first issue Good for newcomers label Feb 26, 2024
Copy link

It appears this issue has been stale for at least 14 days 🗓️. If no action is taken the maintainer team may consider closing the issue. Please reach out if you need feedback or follow up actions from the maintainer team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Stale
Projects
None yet
Development

No branches or pull requests

2 participants